Fix: Detect type errors for bare return statements (#1508) #1524
Conversation
## Changes 1. Added `range` field to `ReturnExplicit` struct to track the return statement location 2. Updated `binding/function.rs` to pass the range when creating `ReturnExplicit` 3. Added type checking in `solve.rs` for bare return ## Testing - ✅ Added 3 new test cases in returns.rs Fixes facebook#1508
ndmitchell
left a comment
ndmitchell
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
grievejia
left a comment
grievejia
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@yangdanny97 could you please let me know what changes i need to make as im not able to see why internal build & tests failed!!! |
|
@AryanBagade I just checked, and it looks like the internal build was failing for an unrelated issue, and Danny's comment was resolved, so no action required here. Thanks for contributing this fix (for a slightly embarrassing bug XD), and sorry the internal review process is so opaque. We wanted to export the review status so contributors can see when their PR is approved, but we don't have fine-grained control over what information is exported. |
|
@yangdanny97 merged this pull request in fc91a0f. |
7 participants
Changes
rangefield toReturnExplicitstruct to track the return statement locationbinding/function.rsto pass the range when creatingReturnExplicitsolve.rsfor bare returnTesting
Fixes #1508